Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup order validate_payments_attributes #2696

Merged
merged 1 commit into from
May 3, 2018
Merged

cleanup order validate_payments_attributes #2696

merged 1 commit into from
May 3, 2018

Conversation

ccarruitero
Copy link
Contributor

I think it's not necessary make a query over available_payment_methods. Until I can see available_payment_methods already return a list of payment methods that are available for the order.

gmacdougall
gmacdougall approved these changes Apr 17, 2018
View reviewed changes
Copy link
Member

@gmacdougall gmacdougall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. Thanks for the contribution!

kennyadsl
kennyadsl approved these changes May 1, 2018
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tvdeyen tvdeyen merged commit 6067791 into solidusio:master May 3, 2018
@tvdeyen
Copy link
Member

tvdeyen commented May 3, 2018

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmacdougall gmacdougall gmacdougall approved these changes

@kennyadsl kennyadsl kennyadsl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ccarruitero @tvdeyen @kennyadsl @gmacdougall