Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add promotion actions and promotion calculators documentation for end users #2755

Merged

Conversation

benjaminwil
Copy link
Contributor

This adds documentation about Solidus's promotion actions and calculators for end users. The audience for this documentation is store administrators or anyone who has to touch the solidus_backend as a business person.

Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The promotion calculators table header should be improved. Other than that 👍

calculator that it should use. You can do this by selecting a value in the
**Calculated By** drop-down menu.

Depending on the [type of promotion action][promotion-action-types] that you are
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing link

@@ -0,0 +1,158 @@
# Promotion calculators

When you create a promotion action, one step is to select the promotion
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a short sentence what a calculator does. It's often not clear for non technical people what this thing is for, besides that it 'calculates things'.

creating, only a subset of the promotion calculators may be available to use.

This table outlines the outlines the available promotions calculators and which
promotion action types they can be applied to:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The header of this table is misleading. There are no promotion action types listed, these are calculables (a term we probably should explain as well).

@benjaminwil benjaminwil force-pushed the user_guides/promotions/promotion_actions branch from 4abea76 to f16d1d9 Compare June 12, 2018 17:55
@benjaminwil
Copy link
Contributor Author

@tvdeyen Thank you for the feedback. I think my most recent commit addresses all your comments.

Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small typo. But this good to go then

@benjaminwil benjaminwil force-pushed the user_guides/promotions/promotion_actions branch from f16d1d9 to 9e617ce Compare June 12, 2018 18:56
@tvdeyen tvdeyen merged commit 72013a8 into solidusio:master Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants