New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making sure order by columns do not collide with other tables #2774

Merged

gmacdougall merged 1 commit into solidusio:master from softr8:improve-price-currently-valid

Jun 29, 2018

Contributor

softr8 commented Jun 14, 2018

With some complex eager loading relationships, it was causing sql sintax errors
referring to multiple tables having the same column name


          Making sure order by columns do not collide with other tables

8c0bbe4

gmacdougall approved these changes

View reviewed changes

Member

gmacdougall left a comment

Thanks for the contribution!

gmacdougall merged commit 7c3ba13 into solidusio:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet