Add an allocator class to extend the Solidus initial allocation logic #2810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jul 24, 2018
houndci-bot
reviewed
Jul 24, 2018
vassalloandrea
force-pushed
the
simple-coordinator-allocator
branch
from
9a64dee to
82971eb
Compare
kennyadsl
previously approved these changes
Jul 25, 2018
ericsaupe
approved these changes
Sep 18, 2018
tvdeyen
reviewed
Sep 18, 2018
vassalloandrea
force-pushed
the
simple-coordinator-allocator
branch
from
82971eb to
636f2b7
Compare
vassalloandrea
force-pushed
the
simple-coordinator-allocator
branch
4 times, most recently
from
8492bba to
f6c7c3e
Compare
vassalloandrea
force-pushed
the
simple-coordinator-allocator
branch
from
f6c7c3e to
db700cf
Compare
jacobherrington
suggested changes
Nov 28, 2018
vassalloandrea
force-pushed
the
simple-coordinator-allocator
branch
from
db700cf to
0b93553
Compare
With this PR we add the possibility to change the stock allocation logic using a custom class without override the allocate_inventory method in SimpleCoordinator.
vassalloandrea
force-pushed
the
simple-coordinator-allocator
branch
from
0b93553 to
f177d85
Compare
jacobherrington
approved these changes
Dec 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we add the possibility to change the stock allocation logic using a custom class without overriding the allocate_inventory method in SimpleCoordinator.
How it works
Default class
Without changing the Solidus default stock allocation, I wrote a
Spree::Stock::Allocator::OnHandFirstallocator with the same logic of theallocate_inventorymethod.How to override Solidus default stock allocation
You can tell the
SimpleCoordinatorto use a custom allocator overriding theSpreeconfiguration:Spree::Config.stock.allocator_classHow to write a custom allocator
To write a custom stock allocator you can extend
Spree::Stock::Allocator::Baseif you also want to change the allocation priority ( on hand first or backorderable first ). Otherwise, you can extendSpree::Stock::Allocator::OnHandFirstto only change the allocation logic.