-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move reports from backend into an extension #2814
Conversation
Thanks, I think we should also move the extension into solidusio-contrib organization before merging. What do you think? |
@kennyadsl sure, what is the process to move the exension into the |
I think you just need to give me admin access to that repo and I can transfer it. Let's talk in Slack for details if you want! |
@kennyadsl I just sent to you the invite, thanks |
@jtapia I think I have to be admin to make the transfer |
@kennyadsl right, my bad, I just did it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I'm thinking we add the 3.0 Milestone to this as this might be an unexpected change for people?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I'm thinking we add the 3.0 Milestone to this as this might be an unexpected change for people?
I don't think we need to wait until 3.0. We moved into extensions in other minor versions as well. We don't break things. Stores that use that reports can easily move them back in.
Sounds good, @tvdeyen |
It will be extracted out of core from the next release, see: solidusio/solidus#2814
Issue
Based on #1262
What it does?