Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move reports from backend into an extension #2814

Merged
merged 1 commit into from
Oct 17, 2018
Merged

Move reports from backend into an extension #2814

merged 1 commit into from
Oct 17, 2018

Conversation

jtapia
Copy link
Contributor

@jtapia jtapia commented Jul 28, 2018

Issue

Based on #1262

What it does?

@kennyadsl
Copy link
Member

Thanks, I think we should also move the extension into solidusio-contrib organization before merging. What do you think?

@jtapia
Copy link
Contributor Author

jtapia commented Aug 7, 2018

@kennyadsl sure, what is the process to move the exension into the solidus-contrib organization?

@kennyadsl
Copy link
Member

I think you just need to give me admin access to that repo and I can transfer it. Let's talk in Slack for details if you want!

@jtapia
Copy link
Contributor Author

jtapia commented Aug 7, 2018

@kennyadsl I just sent to you the invite, thanks

@kennyadsl
Copy link
Member

@jtapia I think I have to be admin to make the transfer

@jtapia
Copy link
Contributor Author

jtapia commented Aug 7, 2018

@kennyadsl right, my bad, I just did it

Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@ericsaupe ericsaupe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'm thinking we add the 3.0 Milestone to this as this might be an unexpected change for people?

Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'm thinking we add the 3.0 Milestone to this as this might be an unexpected change for people?

I don't think we need to wait until 3.0. We moved into extensions in other minor versions as well. We don't break things. Stores that use that reports can easily move them back in.

@ericsaupe
Copy link
Contributor

Sounds good, @tvdeyen

kennyadsl added a commit to solidusio/extensions.solidus.io that referenced this pull request Oct 17, 2018
It will be extracted out of core from the next release, 
see: solidusio/solidus#2814
@kennyadsl kennyadsl merged commit 7e557a2 into solidusio:master Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants