Tracking Number link to Tracking URL page #2829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarednorman
reviewed
Aug 15, 2018
| @@ -50,7 +50,12 @@ | |||
| <tr class="show-tracking total"> | |||
| <td colspan="5"> | |||
| <% if carton.tracking.present? %> | |||
| <strong><%= Spree::Carton.human_attribute_name(:tracking) %>:</strong> <%= carton.tracking %> | |||
| <strong><%= Spree::Carton.human_attribute_name(:tracking) %>:</strong> | |||
| <% if carton.tracking_url.nil? %> | |||
There was a problem hiding this comment.
I'd probably just write this as
<% if carton.tracking_url %>
<%= link_to carton.tracking, carton.tracking_url, target: "_blank" %>
<% else %>
<%= carton.tracking %>
<% end %>
but either way this seems fine.
There was a problem hiding this comment.
Updated, Thank you 😄
jarednorman
approved these changes
Aug 15, 2018
tvdeyen
approved these changes
Aug 16, 2018
skukx
approved these changes
Aug 23, 2018
gmacdougall
approved these changes
Aug 29, 2018
|
😄 Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows showing the tracking URL in the admin panel instead of only the tracking number.