Money#allocate calculates weights already #2836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
also related RubyMoney/monetize#118 (comment) |
tvdeyen
reviewed
Sep 3, 2018
core/solidus_core.gemspec
Outdated
| @@ -35,7 +35,7 @@ Gem::Specification.new do |s| | |||
| s.add_dependency 'discard', '~> 1.0' | |||
| s.add_dependency 'friendly_id', '~> 5.0' | |||
| s.add_dependency 'kaminari-activerecord', '~> 1.1' | |||
| s.add_dependency 'monetize', '~> 1.8.0' | |||
| s.add_dependency 'monetize', '~> 1.9' | |||
There was a problem hiding this comment.
@tvdeyen it does indeed, we don't have to raise the version I can add it back to ~> 1.8 let me konw
There was a problem hiding this comment.
Yes. Please. We want to be as conservative as possible with dependencies
|
I've set monetize back to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to 3f027e2. Assuming build is still green for both monetize 1.8 and 1.9 we can loose that dependency again.