allow multiple taxons on product creation #2840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenMorganIO
reviewed
Sep 10, 2018
| context "adding taxons to a product" do | ||
| let!(:product) { create(:product) } | ||
| let!(:first_taxon) { create(:taxon) } | ||
| let!(:second_taxon) { create(:taxon) } |
There was a problem hiding this comment.
This taxon is needlessly created for the first spec. let! can also be problematic in creating records when you don't need them and can slow test suites down. Using let will solve this.
There was a problem hiding this comment.
Thanks for the feedback @BenMorganIO, changes made. Let me know if there is anything else you can think of!
tvdeyen
reviewed
Sep 11, 2018
ericsaupe
approved these changes
Sep 13, 2018
kennyadsl
approved these changes
Sep 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add private methods for splitting up taxons and option_type_ids on the products controller, addressing a bug that only allowed for one of each to be applied on product creation
refs #2791