Add a Master SKU field to the products form #2875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 27, 2018 06:51
I have come across a use case in which the product's sku attribute needs to be editable by the admin even in the event that the product has variants. This commit adds a user interface element for a Master SKU which updates the Spree::Product's sku attribute. It is visible regardless of the number of variants, which satisfies my use case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have come across a use case in which the product's sku attribute needs to be
editable by the admin even in the event that the product has variants. This
commit adds a user interface element for a Master SKU which updates the
Spree::Product's sku attribute. It is visible regardless of the number of
variants, which satisfies my use case.
Solves #2874
A product with variants and a product SKU:
A product with variants and no product SKU:
A product with no variants and a product SKU:
