Improve trustworthiness of a content items price. #2897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't believe that the Netlify test failures are due to changes that I've made. Seems to be checking solidus guides and I have not made any changes to those said guides. |
|
Please rebase to get rid of the Netlify errors. |
jacquesporveau
force-pushed
the
jacquesporveau/fix-content-item-bugs
branch
from
5edca04 to
05cd72d
Compare
gmacdougall
approved these changes
Oct 6, 2018
added 2 commits
October 9, 2018 08:59
There is a bug taking place in this class that I plan to fix. Before I do that I want to place the class under test to observe it's current beaviour and make my bugfix more obvious.
A line items price is more trustworthy than a variants price in regards to what a customer is paying for something.
jacquesporveau
force-pushed
the
jacquesporveau/fix-content-item-bugs
branch
from
05cd72d to
351bb48
Compare
tvdeyen
approved these changes
Oct 11, 2018
|
Thanks guys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A line items price is more trustworthy than a variants price in regards
to what a customer is paying for something.
In the case that there are applications that charge different prices for variants based on criteria then using a line items price is a more accurate representation and a better source of truth as to what someone will pay for an item.
For shipping calculators that depend on how much something is costs this is an improvement.