Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix translations keys #2902

Conversation

bitberry-dev
Copy link

Hi guys,

In admin, at order page in cart tab summary renders without translations for shipment and payment states.
I fixed it
2018-10-07 21 49 35
.

Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense, I've manually re-triggered the failing jobs on CircleCi and they should pass now!

Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small thing if you have time that would improve the PR documentation. Can you please reword the commit message to include some more relevant information? Like Fix backend order summary state translation keys.

Thanks!

@bitberry-dev
Copy link
Author

bitberry-dev commented Oct 10, 2018

Thought that branch name will be enough.
Commit message changed :)

@kennyadsl
Copy link
Member

Now there are 3 commits, the goal is to have just the correct one, I think you just need to squash them, thanks!

@bitberry-dev bitberry-dev force-pushed the bugfix/fix_states_translations_in_admin_order_summary branch from a6c8105 to f4e92e5 Compare October 10, 2018 12:02
@bitberry-dev
Copy link
Author

Squashed

Copy link
Contributor

@ericsaupe ericsaupe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kennyadsl kennyadsl merged commit 86992a5 into solidusio:master Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants