Spree::FulfilmentChanger stock allocation fix #2908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spaghetticode
force-pushed
the
fix_fullfilment_charger_allocation
branch
from
7f71d0e to
002d785
Compare
|
@spaghetticode can you please rebase against master? Failures should go away |
spaghetticode
force-pushed
the
fix_fullfilment_charger_allocation
branch
from
002d785 to
f966575
Compare
kennyadsl
reviewed
Oct 19, 2018
When splitting a shipment item to the same stock location, if the stock location has currently zero availability for that product then the state of the target shipment inventory unit should be determined by the original shipment inventory unit state: * when originally backordered, as there is still no available stock, then it should remain backordered * when originally on hand, then it should remain on hand, as there is no actual stock movement in this case (the fact that the stock location now has no availability for that product is not actually relevant) A clarifying example for the second scenario: * stock location L has 1 unit for product A * customer purchases 1 unit of product A * the order is created with product A on hand * product A is automatically included in shipment S * stock location L is now empty (0 units) for product A * if the admin splits product A from shipment S to a new shipment from the very same stock location L, product A should remain on hand also in the new shipment
spaghetticode
force-pushed
the
fix_fullfilment_charger_allocation
branch
from
f966575 to
0921e00
Compare
kennyadsl
approved these changes
Oct 19, 2018
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When splitting a shipment item to the same stock location, if the stock location has currently zero availability for that product then the state of the target shipment inventory unit should be determined by the original shipment inventory unit state:
when originally backordered, as there is still no available stock, then it should remain backordered
when originally on hand, then it should remain on hand, as there is no actual stock movement in this case (the fact that the stock location now has no availability for that product is not actually relevant)
A clarifying example for the second scenario: