Improve text in "new promotions" form for better usability #2917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelmichael
changed the title
tvdeyen
reviewed
Oct 14, 2018
|
Thanks! Rebased. |
ericsaupe
suggested changes
Oct 15, 2018
Add character limit to description on Promotions form Add English translation for character limit Change 'Add rule of type' to 'Discount rules' on promotions form. Change same in specs Change 'Add rule of type' to 'Adjustment type'. Fix specs accordingly Update promotion_adjustment_spec to match new verbiage for promotion UI Change some headers to Title Case Standardize code blocks, fix wrong syntax highlighting Convert headings to sentence style capitalization I made this change based on PR feedback. Use bash for syntax highlighting instead of shell shell does not provide syntax highlighting in GitHub's markdown. Using bash will provide more accurate highlighting. Remove 'General' title from top of promotions admin page Add character limit to description on Promotions form Add English translation for character limit Change 'Add rule of type' to 'Discount rules' on promotions form. Change same in specs Change 'Add rule of type' to 'Adjustment type'. Fix specs accordingly Update promotion_adjustment_spec to match new verbiage for promotion UI Dont need to lockdown autoprefixer-rails.
|
Thanks @michaelmichael, we need more PRs like this one! |
|
Thanks guys. I didn't know contributing to Solidus would be so easy. Hope to contribute more. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes issues raised in #1960 with the following exceptions:
I didn't add a character counter to the description, just static text, so no bonus points. We can leave the issue open, and I can try resolving it later.
It looks like the following issues have been already fixed-ish:
"Base Calculator" had already been changed to "Calculated by", and the currency symbol was already prepended to the currency input field