Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize capitalization #2943

Merged

Conversation

jacobherrington
Copy link
Contributor

@jacobherrington jacobherrington commented Nov 11, 2018

I went through and tried to clean up some of the more inconsistent sets of capitalization. This may not be perfect, but it's much more consistent and adds some polish to the UX.

@jacobherrington
Copy link
Contributor Author

Just realized this will probably break some UI tests. 😆 I'll try to make those changes where necessary.

Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know much about english capitalization rules, but this looks ok for me.

Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kennyadsl
Copy link
Member

Maybe you could squash all commits into a single one with a better description?

This commit is focused on making the capitalization more consistent
because at the moment it seems very random. I'm sure that this PR will
not solve this issue, as it will be an ongoing effort to improve this
part of the UX, but at least it's a start.
@jacobherrington jacobherrington force-pushed the chore/standardize-capitalization branch from 4d677b4 to 4ec3571 Compare November 20, 2018 16:58
@jacobherrington
Copy link
Contributor Author

@kennyadsl done!

@tvdeyen tvdeyen merged commit bb64520 into solidusio:master Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants