Bug/remove mini image from admin view #2976
Conversation
There was a problem hiding this comment.
@nvh0412 Thanks for making a PR!
There are definitely some deletions in here that shouldn't be, do you mind fixing that?
nvh0412
force-pushed
the
bug/remove_mini_image_from_admin_view
branch
from
56acf79 to
feb58d6
Compare
|
It looks like you picked up 42d6c9c by accident! |
|
@jacobherrington a mistake with my git tree, I fixed. Thanks so much, jacob 💯 |
|
@jacobherrington seems like we have a flaky test https://circleci.com/gh/solidusio/solidus/10020#tests/containers/1, ironically I can't rerun to make it pass. |
|
@nvh0412 Yes, I believe that test is a bit flaky. It keeps showing up in various PRs. |
|
@jacobherrington so we have to wait for the fix of this flaky test to merge this PR? |
|
I don't think this PR is related, but I'd like to figure out why the test is red before approving. |
|
@jacobherrington did anyone fix the flaky test? |
|
@nvh0412 In this case, no, I just reran the test suite. That test is not failing because of your PR, it needs to be addressed as its own issue. |
Description
This PR has been created to fix #2975
mini_imagehelperspree/admin/shared/imageinstead with image from gallery