Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Spree::Variant#should_track_inventory? to disable 'Count on hand' input #2977

Merged
merged 1 commit into from
Nov 28, 2018
Merged

Use Spree::Variant#should_track_inventory? to disable 'Count on hand' input #2977

merged 1 commit into from
Nov 28, 2018

Conversation

aitbw
Copy link
Contributor

@aitbw aitbw commented Nov 27, 2018

Refs: #2960

This patch improves said PR by fixing a bug that enabled the Count on hand input without taking into consideration the Spree::Config.track_inventory_levels setting.

kennyadsl
kennyadsl approved these changes Nov 27, 2018
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!

jacobherrington
jacobherrington approved these changes Nov 27, 2018
View reviewed changes
Copy link
Contributor

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @aitbw! Thanks for the PR.

@kennyadsl kennyadsl merged commit ceae80f into solidusio:master Nov 28, 2018
@aitbw aitbw deleted the nebulab/improve-track-inventory-ux branch November 28, 2018 14:41
@aitbw aitbw mentioned this pull request Nov 28, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobherrington jacobherrington jacobherrington approved these changes

@kennyadsl kennyadsl kennyadsl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aitbw @kennyadsl @jacobherrington