Normalize API I18n keys #2988
Merged
Normalize API I18n keys #2988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aitbw
force-pushed
the
nebulab/normalize-api-i18n
branch
from
dd89378 to
479eb21
Compare
What do you mean? Which configuration should this file contain in order to make the CI step work? |
|
@kennyadsl, I meant maybe we could do something like this, but I'm more fond of the first option. |
|
if it's possible, I'm ok removing scope. |
aitbw
force-pushed
the
nebulab/normalize-api-i18n
branch
from
479eb21 to
d3849fb
Compare
houndci-bot
reviewed
Feb 25, 2019
aitbw
force-pushed
the
nebulab/normalize-api-i18n
branch
from
d3849fb to
f111db3
Compare
|
@aitbw I'm not certain we need it, but can you rebase just to be safe? |
`i18n-tasks` was complaining about unused translations when using the `scope` option
aitbw
force-pushed
the
nebulab/normalize-api-i18n
branch
from
f111db3 to
303b36d
Compare
Some Core/API I18n keys were placed in the incorrect files, which caused `i18n-tasks` to complain about unused/missing translations
aitbw
force-pushed
the
nebulab/normalize-api-i18n
branch
from
303b36d to
99bbf5b
Compare
|
Done @jacobherrington! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the work established by #2963, this PR normalizes the I18n keys for the API.
That said, some issues are pending when running
bundle exec i18n-tasks health, as you can see below:We have two (2) options to fix this:
Assuming the
scopeusage is the reason for these issues, remove this option and replace it withI18n.t('spree.api.my_key')Include a
i18n-tasks.ymlconfig file underconfigand consider allspree.apiI18n keys usedWe need to address this last issue to include an I18n health check to the CI (first mentioned in here) in order to stay consistent within this regard.