Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize shared resource links #2997

Merged
merged 1 commit into from
Dec 13, 2018

Conversation

brchristian
Copy link
Contributor

Currently there is a difference between new_resource_links and edit_resource_links. Namely, in one the Cancel button is of class: 'button' and in the other the Cancel button is of class: 'btn btn-primary'.

Based on how they render in the browser, I assume that new_resource_links (class: 'button') is correct, as it looks like this:

screen shot 2018-12-10 at 9 58 07 am

Whereas the shared_resource_links (class: 'btn btn-primary') looks like this, with a weird visual bug:

screen shot 2018-12-10 at 9 55 10 am

After this commit, which changes shared_resource_links to be similar to new_resource_links, the visual behavior is fixed and it looks like this:

screen shot 2018-12-10 at 9 55 19 am

Copy link
Contributor

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @brchristian!

Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

I also have the feeling that we can remove class: 'btn btn-primary' from all the <button> elements since it looks like they already have the same css. But of course this should be handled into another PR.

@jacobherrington jacobherrington merged commit 168b40c into solidusio:master Dec 13, 2018
@brchristian brchristian deleted the patch-4 branch December 13, 2018 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants