Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating readme to include OpenCollective information #3042

Merged
merged 1 commit into from
Jan 31, 2019
Merged

Updating readme to include OpenCollective information #3042

merged 1 commit into from
Jan 31, 2019

Conversation

seand7565
Copy link
Contributor

Adds OpenCollective badges to the readme - as well as a Key Stakeholder avatars.

Related to PR #2931

@jacobherrington jacobherrington mentioned this pull request Jan 17, 2019
Closed
jacobherrington
jacobherrington approved these changes Jan 17, 2019
View reviewed changes
Copy link
Contributor

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @seand7565 👍

I really like the SVG that OC provides for us.

@jacobherrington
Copy link
Contributor

jacobherrington commented Jan 17, 2019 •
edited
Loading

Re-running specs, touching a markdown file shouldn't cause a feature spec to fail.

spaghetticode
spaghetticode approved these changes Jan 28, 2019
View reviewed changes
Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seand7565 👏thank you!

aitbw
aitbw approved these changes Jan 29, 2019
View reviewed changes
Copy link
Contributor

@aitbw aitbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, @seand7565 👏

kennyadsl
kennyadsl reviewed Jan 30, 2019
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, I think we can even merge this but it will need to be revisited later.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@jacobherrington
Copy link
Contributor

I'm happy with this as is, what do you think @kennyadsl?

kennyadsl
kennyadsl approved these changes Jan 31, 2019
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's ok now and we can easily iterate on it later if needed.

@jacobherrington jacobherrington merged commit f7a9564 into solidusio:master Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobherrington jacobherrington jacobherrington approved these changes

@aitbw aitbw aitbw approved these changes

@kennyadsl kennyadsl kennyadsl approved these changes

@spaghetticode spaghetticode spaghetticode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@seand7565 @jacobherrington @spaghetticode @kennyadsl @aitbw