Issue 2868: Products at multiple Stock Locations appear as unique variants

[mayanktap]

Description

This PR deals with the fix for the following issue:
#2868

Ref # (issue)

Checklist:

• Pull Request guidelines are respected
• Documentation/Readme have been updated accordingly
• Changes are covered by tests (if possible)
• Each commit has a meaningful message attached that described WHAT changed, and WHY

[mayanktap]

Hi @spaghetticode ,

This is the new PR(replacement for #2898) that consist the resolution for issue: #2868
Please have a look and let me know in case of any discrepancy.

[spaghetticode]

@mayanktap I see there are three commits, two of them seems to me to be merge commits. Can you remove them?

This gist may help if you have problems updating the code on your local fork.

[mayanktap]

@spaghetticode ,
Can we also proceed with making it a single commit by marking the two other commit as fixup?
Otherwise I will proceed with the above.

[spaghetticode]

@mayanktap I'm not sure I understand your last comment. the ideal situation for this PR is to have only one commit, this one which includes both the code and the spec. I think both code and spec can live in a single commit as they're minimal.

The other 2 commits should be removed, as they are merge commits that don't belong to this PR.

I hope this helps :)

[mayanktap]

@spaghetticode ,

Done. Please check.

[spaghetticode]

@mayanktap looks good to me, thank you!

[mayanktap]

@jacobherrington , @ericsaupe
Can you please review the changes?

[jacobherrington]

Thanks for this PR @mayanktap! Great work between you and @spaghetticode 🖖

[aitbw]

Looks good to me, great work @mayanktap ! 👏