Exclude line item additional taxes from unit cancel adjustment amount #3072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Feb 4, 2019
mdesantis
force-pushed
the
exclude-line-item-additional-taxes-from-unit-cancel-adjustment-amount
branch
from
e7ed796 to
df9a7f3
Compare
spaghetticode
approved these changes
Feb 4, 2019
jacobherrington
approved these changes
Feb 4, 2019
kennyadsl
reviewed
Feb 4, 2019
There was a problem hiding this comment.
@mdesantis thanks for the fix. I think it could be useful to split this change into two different commits, one that refactors only and the other that makes the change so it will be easier to understand what/how changed. WDYT?
|
@kennyadsl good suggestion! I agree |
Fixes solidusio#3068. It takes into account the line item taxes amount during calculation of line item amount on line item cancellation.
Related to solidusio#3068. In order to keep code consistency, I made a refactoring along the same lines of `core/app/models/spree/calculator/returns/default_refund_amount.rb`, which performs a similar calculation.
mdesantis
force-pushed
the
exclude-line-item-additional-taxes-from-unit-cancel-adjustment-amount
branch
from
df9a7f3 to
d822a08
Compare
|
@kennyadsl commit splitting 👍 |
kennyadsl
approved these changes
Feb 11, 2019
mdesantis
deleted the
exclude-line-item-additional-taxes-from-unit-cancel-adjustment-amount
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3068. It takes into account the line item taxes amount during calculation of line item amount on line item cancellation.
In order to keep code consistency, I made a refactoring along the same lines of
core/app/models/spree/calculator/returns/default_refund_amount.rb, which performs a similar calculation.Ref #3068
Checklist: