Deprecate core tasks and migration scripts #3080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't even know if this works with master since this is not tested. We should not maintain this kind of scripts.
Do we really need to test email sending this way?
This was needed for the v2.2 -> v2.3 upgrade and it should not be needed anymore. This also changes the database migration since we are sure it will never execute any operation after the upgrade. Changing the migration allows us to deprecate the class responsible for actually doing the change, which is the same called in the deprecated rake task. For the original implementation see: https://github.com/solidusio/solidus/pull/2001/files
This task is present since Solidus v1.0 and it should just be used during the update to v1.1.
This is a version upgrade helper, no need to keep it.
up and down tasks. They are migration helpers, no need to keep them.
ericsaupe
approved these changes
Feb 6, 2019
jacobherrington
approved these changes
Feb 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have a lot of tasks and scripts used as helpers during versions upgrades. These files can be removed so I started deprecating them. They should not be used by anyone but if that's the case they will be noticed before the removal.
Checklist: