Remove destructive actions from migration 20180710170104 #3109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing tables and renaming columns are destructive actions as they change the DB schema in a way that is likely to be not compatible with previous code. This is especially dangerous when deploying multi-instance applications as migrations can run before all instances code is synced. When this happens, these instances may experience severe downtime due to high error rates. So destructive changes should be done in subsequent deploys: first add the new table and columns, then later remove the stale ones. Table `spree_store_credit_update_reasons` and its column `update_reason_id` will need to be removed in a future release of Solidus.
spaghetticode
force-pushed
the
spaghetticode/safer-migration-20180710170104
branch
from
8aa9001 to
da25ae7
Compare
2 tasks
tvdeyen
approved these changes
Feb 20, 2019
jacobherrington
approved these changes
Feb 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removing tables and renaming columns are destructive actions as they change the
DB schema in a way that is likely to be not compatible with previous code.
This is especially dangerous when deploying multi-instance applications as
migrations can run before all instances code is synced. When this happens,
these instances may experience severe downtime due to high error rates.
So destructive changes should be done in subsequent deploys: first add the new
table and columns, then later remove the stale ones.
Table
spree_store_credit_update_reasonsand its columnupdate_reason_idwill need to be removed in a future release of Solidus.
Checklist: