Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set mininum line item quantity in admin cart #3115

Merged

Conversation

mamhoff
Copy link
Contributor

@mamhoff mamhoff commented Feb 20, 2019

Description
It does not make much sense to add zero of anything to an order. This
commit changes the minimum quantity for a line item in the admin cart to
one.

Checklist:

I don't think a test is necessary for this change.

It does not make much sense to add zero of anything to an order. This
commit changes the minimum quantity for a line item in the admin cart to
one.
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense, thanks @mamhoff ! 👍

Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely. Thanks 👏

@kennyadsl
Copy link
Member

kennyadsl commented Feb 20, 2019

I'm giving a live try to this PR. I think it's ok as is since it does not allow you to set 0 as value by using browser's number input controls. Anyway, a user is still able to fill that input with 0 and submit. I think this happens since the submit of that form is never really called. Maybe it's just matter of triggering the validation programmatically in the backbone view?

Copy link
Contributor

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good as it is, of course there may be room for improvement as @kennyadsl has said.

@kennyadsl kennyadsl merged commit d838a56 into solidusio:master Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants