Ensure return from CSS function #3146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the `sassc` compiler, all CSS functions should ensure that they do not end without a `@return` statement. The `very-light` function has the possibility that it could exit without calling such a statement, so we add a catchall `@return` at the end to return the unmodified color value.
jacobherrington
approved these changes
Mar 15, 2019
|
@fastjames thanks! Can you please post the error you are receiving as well? |
aitbw
approved these changes
Mar 15, 2019
There was a problem hiding this comment.
Looks like this change is needed as per libsass v3.5, after this patch was merged.
I'd need to see the error that you and your team found for confirmation, but this looks reasonable to me. Thanks @fastjames 💪
|
Sorry for the delay, I have been unable to get back to this today to reproduce and record the error. Will do so as soon as I can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When compiling SCSS, the newly included
sassccompiler seems to be more vigilant about logic checks. In particular, it returns an error if a CSS function ends without a@returnstatement. Thevery-lightfunction has the possibility of doing that, which causes such an error when we test our solidus app against v2.8.2.I am not sure if it's possible to write tests for css functions, and I do not see any existing tests that appear to target them so I assume that's not a requirement right now.
Checklist: