Fix DB-specific, query-related exceptions #3156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aitbw
force-pushed
the
aitbw/fix-pg-query-error
branch
from
36b3e97 to
cf69397
Compare
aitbw
changed the title
aitbw
force-pushed
the
aitbw/fix-pg-query-error
branch
from
cf69397 to
a45d47f
Compare
kennyadsl
reviewed
Apr 1, 2019
aitbw
force-pushed
the
aitbw/fix-pg-query-error
branch
from
a45d47f to
49a3dbe
Compare
spaghetticode
approved these changes
Apr 3, 2019
There was a problem hiding this comment.
👍 thank you @aitbw for this much needed fix!
I've left a minor comment, hope it makes sense
PostgreSQL is very picky when building a SQL query that requires SELECT and ORDER BY methods; the attribute you want to use to sort the results must be explicitly selected; otherwise, PG raises an exception
The SQL queries specified on said helper on lines 10 and 15 were redundantly selecting the `id` attribute for `spree_products` table, which caused MySQL to raise an exception about a duplicate column name since said attribute is already being selected through the `spree_products.*` statement
aitbw
force-pushed
the
aitbw/fix-pg-query-error
branch
from
49a3dbe to
3db4c93
Compare
kennyadsl
approved these changes
Apr 3, 2019
|
@solidusio/core-team can we have another review here, please? This issue is making all other PRs fail. |
gmacdougall
approved these changes
Apr 3, 2019
This was referenced Apr 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I was being greeted with the following errors when running specs specifying PostgreSQL or MySQL as database engine:
PG::InvalidColumnReferenceThis was happening because PG is extremely picky when using the
SELECTandORDER BYmethods; it requires that the developer must explicitly select the attribute(s) that are going to be used to sort the query results.Mysql2::Error: Duplicate column nameThis exception was being raised because the affected code was selecting the
idattribute forSpree::Producttwice. (It was being already selected by thespree_products.*statement)See the following failed builds as reference for the errors:
The issue is present from Rails v5.2.3 onwards, seems like rails/rails#35361 introduced this regression. (shoutout to @kennyadsl and @spaghetticode for pointing this out to me)
Checklist: