Fix stock item form to allow changing backorder value #3159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennyadsl
added
type:bug
The form controls to submit the stock item form was not displayed if only the backorder checkbox changed.
kennyadsl
force-pushed
the
kennyadsl/fix-stock-backordered
branch
from
1d70d0a to
64769ad
Compare
spaghetticode
approved these changes
May 28, 2019
ericsaupe
approved these changes
May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug on the admin stock item forms that I discovered yesterday, probably introduced in #2862.
The form controls to submit the stock item form was not displayed if the backorder checkbox was the only attribute changed. This is wrong since we could need to change that value without also changing the count on hand value.
This PR fixes this bug by considering also the backorder value changes when we decide if showing the stock item form or not.
Before
After
Checklist: