Enable extension developers to customize the namespace #3161
Conversation
mdesantis
force-pushed
the
enable-extension-developers-to-customize-the-namespace
branch
from
9cb6bc7 to
f3e564a
Compare
| @@ -24,7 +24,7 @@ | |||
| begin | |||
| require "generators/#{ENV['LIB_NAME']}/install/install_generator" | |||
| puts 'Running extension installation generator...' | |||
| "#{ENV['LIB_NAME'].camelize}::Generators::InstallGenerator".constantize.start(["--auto-run-migrations"]) | |||
| "#{ENV['LIB_NAMESPACE'] || ENV['LIB_NAME'].camelize}::Generators::InstallGenerator".constantize.start(["--auto-run-migrations"]) | |||
There was a problem hiding this comment.
Does LIB_NAMESPACE need to be camelize as well? Should this be #{(ENV['LIB_NAMESPACE'] || ENV['LIB_NAME']).camelize}
There was a problem hiding this comment.
@ericsaupe I don't think so, because LIB_NAMESPACE is meant to be the Solidus extension gem namespace, it isn't used as a file path, so it doesn't make sense to pass it in a file path form; I meant to use LIB_NAMESPACE in order to skip transformations, so f.e. in this way:
LIB_NAME=solidus_graphql_api LIB_NAMESPACE=SolidusGraphQLAPI bundle exec rake test_app
Do you think we could refactor in a better way the flow? I was thinking about that but unfortunately it didn't come me to mind anything better
There was a problem hiding this comment.
Makes sense to me! Thanks for the explanation.
mdesantis
force-pushed
the
enable-extension-developers-to-customize-the-namespace
branch
from
f3e564a to
0f73e06
Compare
|
@mdesantis can you please rebase against master now? |
|
@kennyadsl FYI I rebased with master a couple of hours ago and surprisingly tests are still failing; I'm going to try again |
If you are developing an extension and you want to use `Rake::Task['extension:test_app']` you are forced to have a file named exactly as the capitalized version of the extension namespace name, so if you name your namespace extension e.g. SolidusGraphQL you are forced to create a file named `solidus_graph_q_l`, otherwise the following error is raised: ``` > bundle exec rake test_app --trace ** Invoke default (first_time) ** Invoke first_run (first_time) ** Execute first_run ** Invoke test_app (first_time) ** Execute test_app ** Invoke extension:test_app (first_time) ** Execute extension:test_app ** Invoke common:test_app (first_time) ** Execute common:test_app rake aborted! LoadError: cannot load such file -- solidus_graph_q_l ``` This change allows the developer to customize the extension namespace setting a `LIB_NAMESPACE` environment variable.
mdesantis
force-pushed
the
enable-extension-developers-to-customize-the-namespace
branch
from
0f73e06 to
8241630
Compare
|
I've just merged #3202 that should fix the build |
Description
If you are developing an extension and you want to use
Rake::Task['extension:test_app']you are forced to have a file named exactly as the capitalized version of the extension namespace name, so if you name your namespace extension e.g. SolidusGraphQL you are forced to create a file namedsolidus_graph_q_l, otherwise the following error is raised:This change allows the developer to customize the extension namespace setting a
LIB_NAMESPACEenvironment variable.Checklist: