Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase Capybara window width size #3171

Merged
merged 1 commit into from
Apr 15, 2019
Merged

Increase Capybara window width size #3171

merged 1 commit into from
Apr 15, 2019

Conversation

aitbw
Copy link
Contributor

@aitbw aitbw commented Apr 11, 2019 •
edited
Loading

Description

Increasing Capybara window width size may help solve some JS-related issues, such as not being able to click an element because some JS element is "blocking" the view (i.e.: datepicker); this happens because these elements are not automatically dismissed under test environments

#3166 may find this useful

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)

@aitbw
Increase Capybara window width size
44974df 
Increasing Capybara window width size may help solve some JS-related
issues, such as not being able to click an element because some JS
element is "blocking" the view (i.e.: datepicker); this happens because
these elements are not automatically dismissed under test environments
@aitbw aitbw force-pushed the chore/big-capybara branch from 49a3bf5 to 44974df Compare April 11, 2019 14:28
@aitbw aitbw changed the title Maximize Capybara window size Increase Capybara window width size Apr 11, 2019
jacobherrington
jacobherrington approved these changes Apr 11, 2019
View reviewed changes
Copy link
Contributor

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

kennyadsl
kennyadsl approved these changes Apr 15, 2019
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this wasn't the issue on #3166 but I'm still ok raising the capybara browser width. Both are ok and if this one gives us fewer issues, why not?

@kennyadsl kennyadsl merged commit ee1038f into solidusio:master Apr 15, 2019
@aitbw aitbw deleted the chore/big-capybara branch April 15, 2019 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobherrington jacobherrington jacobherrington approved these changes

@JuanCrg90 JuanCrg90 JuanCrg90 approved these changes

@kennyadsl kennyadsl kennyadsl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aitbw @kennyadsl @JuanCrg90 @jacobherrington