Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add active merchant reference URL in Guides #3188

Merged
merged 1 commit into from
Apr 24, 2019
Merged

Add active merchant reference URL in Guides #3188

merged 1 commit into from
Apr 24, 2019

Conversation

jacquesporveau
Copy link
Contributor

@jacquesporveau jacquesporveau commented Apr 17, 2019 •
edited
Loading

Description
There was no url reference here so this wasn't doing what we thought it was.

Before
Screen Shot 2019-04-17 at 3 07 39 PM

After
Screen Shot 2019-04-17 at 3 06 45 PM

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)

jacobherrington
jacobherrington approved these changes Apr 17, 2019
View reviewed changes
Copy link
Contributor

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good idea! Thanks @jacquesporveau 👍

kennyadsl
kennyadsl approved these changes Apr 24, 2019
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kennyadsl kennyadsl merged commit 9d481e9 into solidusio:master Apr 24, 2019
@kennyadsl kennyadsl changed the title Add active merchant reference URL Add active merchant reference URL in Guides Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobherrington jacobherrington jacobherrington approved these changes

@kennyadsl kennyadsl kennyadsl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacquesporveau @kennyadsl @jacobherrington