-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a rails application template for Heroku + example-app #3206
Use a rails application template for Heroku + example-app #3206
Conversation
5a41959
to
7318598
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. This does make some assumptions as to services like Cloudinary and Memcachier but since this is meant as an example app I think those are fine choices that are easily changed by the user.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing blocking, just a small typo.
I think this is a fine option. Thanks for the work @elia!
|
||
if ENV['UPDATE_EXAMPLE_APP_REPO'] | ||
git remote: %{ add origin [email protected]:solidusio/solidus-example-app.git } | ||
git push: %{ --force --set-upstream origin master } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't sure about using --force
here without asking the user for confirmation, but I talked myself into being okay with it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea is to have something that can be automated and requires as few interaction as possible. That's only for the chore of updating the example app after a release of course, it doesn't happen when used as an app template.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, and worst case scenario we just regenerate the example app. The repo we are pushing to will not contain anything we would be afraid to lose.
Yes, given it's going to be deployed on heroku I looked for services that had a free tier and were at the same time viable for production use (using a cache and a CDN are both very good practices for any production store). |
f201121
to
f0d7783
Compare
@elia I moved the repo from Are we good to go? |
I'll remove the last commit and we're good! 🚀 |
The app template should be used to regularly generate a Rails app which will have its own app.json and will be a good base to deploy to heroku, but also to fork download to start a solidus store.
f0d7783
to
698f1f8
Compare
@kennyadsl done, and also regenerated the app to with the solidusio heroku button link 👍 |
Description
The current heroku deploy button is partially broken and uses a custom buildpack.
This PR introduces a reusable rails application template that can be used to generate and update a demo-app (presumably published at https://github.com/solidusio/solidus-example-app).
The app will have its own app.json and will be a good base for deploys to heroku, but also
for forks. Heroku deploys should be already on the right path for production use (cache, images, etc.)
The template can also be used as an executable to build the official demo app:
Demo app
The resulting code is available here: https://github.com/nebulab/solidus-example-app
I just had to change the heroku button url to point at the nebulab org instead of solidusio, other than that it's straight out of the template.
See it in action: https://elia-solidus-demo.herokuapp.com
Screenshots
Checklist: