Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve JS linting, pt. 2 #3225

Merged
merged 2 commits into from
Jun 13, 2019
Merged

Conversation

aitbw
Copy link
Contributor

@aitbw aitbw commented Jun 11, 2019

Description

Keeping up with the changes introduced via #3167 and #3212, this PR removes a now-obsolete, backend-only ESLint config and whitelists all existing offenses so they can be fixed in upcoming PRs.

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • [ ] I have updated Guides and README accordingly to this change (if needed)
  • [ ] I have added tests to cover this change (if needed)

Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @aitbw !

@kennyadsl kennyadsl merged commit 6c92b0e into solidusio:master Jun 13, 2019
@aitbw aitbw deleted the aitbw/js-linting-pt-2 branch June 17, 2019 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants