Purify guides search terms before using them #3230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had an XSS vulnerability that allows to inject code using an URL like: https://guides.solidus.io/search/?inputSearch=%22%3Ciframe+src%3Djavascript%26colon%3Balert%26lpar%3B%22H%26period%3Backed%22%26rpar%3B%3E%22 Purifying the string that is passed to the search engine fixes the issue.
spaghetticode
approved these changes
Jun 17, 2019
|
Merging without respecting the 24-hour waiting policy for security reasons. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We had an XSS vulnerability that allows injecting code in the page. Purifying the string that is passed to the search engine fixes the issue.
Checklist:
I have updated Guides and README accordingly to this change (if needed)I have added tests to cover this change (if needed)