Add dimensions and weight to product samples #3291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm adding weight, height, width and depth to all products added by product samples file.
spaghetticode
approved these changes
Aug 2, 2019
jacobherrington
approved these changes
Aug 4, 2019
There was a problem hiding this comment.
I am fine with this, thanks for helping out @BravoSimone! 🥇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm adding weight, height, width, and depth to all products added by product samples file. I decided to add this data when I run in a simple issue adding Easypost to my project. In development didn't work properly because products didn't have a proper weight set. I think this should be set directly into the solidus gem since we already have samples here and would fix all these kind of issues.
Checklist: