-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing entries to en yml #3313
Merged
kennyadsl
merged 10 commits into
solidusio:master
from
delphaber:add_missing_entries_to_en_yml
Aug 27, 2019
Merged
Add missing entries to en yml #3313
kennyadsl
merged 10 commits into
solidusio:master
from
delphaber:add_missing_entries_to_en_yml
Aug 27, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<th><%= Spree::ShippingMethod.human_attribute_name(:available_to_users) %></th>
`state_id` is alreasy use to define the stock location state (like Alabama). So I added a `state` translation that means "status". This pattern is already used in `spree/admin/refund_reasons/index.html.erb`: `<th><%= Spree::RefundReason.human_attribute_name(:state) %></th>`
`<th><%= Spree::RefundReason.human_attribute_name(:state) %></th>`
Translation is already present
`<th><%= Spree::TaxRate.human_attribute_name(:tax_categories) %></th>`
`<th><%= Spree::Promotion.human_attribute_name(:uses) %></th>`
ericsaupe
approved these changes
Aug 26, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks!
kennyadsl
reviewed
Aug 27, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @delphaber! ❤️
kennyadsl
approved these changes
Aug 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While doing this PR ( solidusio/solidus_i18n#162 ), I noticed that some translations were missing in solidus
en.yml
.I created a single commit per change, but I can rebase and squash them if you prefer :)
Checklist: