Added empty cart button in admin cart #3316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The frontend has an empty cart button and the API supports an empty cart call. This adds that functionality to the backend interface.
kennyadsl
approved these changes
Aug 29, 2019
There was a problem hiding this comment.
Thanks @ericsaupe, great work! Going to only change the PR title so it will be easier to add a Changelog entry on the next release.
kennyadsl
changed the title
pelargir
reviewed
Feb 11, 2020
| } | ||
|
|
||
| this.model.empty({ | ||
| success: () => { |
There was a problem hiding this comment.
Due to the ES6 arrow syntax on this one line, Uglifier has to be put in harmony mode to run Solidus 2.10. This should probably be changed back to ES5 syntax for better compatibility. We shouldn't have to run Uglifier in harmony mode just to get this one line to minify properly.
There was a problem hiding this comment.
Good catch, Matt! We would need to either process this file with Babel or update the syntax. I vote for the latter.
@pelargir want to send a PR?
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The frontend has an empty cart button and the API supports an
empty cart call. This adds that functionality to the backend
interface.
Checklist: