Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sample imgs with wrong file extension #3343

Merged
merged 1 commit into from
Sep 23, 2019
Merged

Update sample imgs with wrong file extension #3343

merged 1 commit into from
Sep 23, 2019

Conversation

mfrecchiami
Copy link
Contributor

On Solidus Slack, #support channel, a user notified this error:

rake aborted!
ActiveRecord::RecordInvalid: Validation failed: Filename has contents that are not what they are reported to be

This commit fixes the incriminated images of the sample store, that weren't .png files, actually

jacobherrington
jacobherrington approved these changes Sep 23, 2019
View reviewed changes
Copy link
Contributor

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof! Nice catch!

Thanks @mfrecchiami 🏉

@jacobherrington jacobherrington merged commit b76c1dd into solidusio:master Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobherrington jacobherrington jacobherrington approved these changes

@kennyadsl kennyadsl kennyadsl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mfrecchiami @kennyadsl @jacobherrington