Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle deprecation for Rails 6 in DummyApp #3352

Merged
merged 1 commit into from
Sep 27, 2019
Merged

Handle deprecation for Rails 6 in DummyApp #3352

merged 1 commit into from
Sep 27, 2019

Conversation

cedum
Copy link
Contributor

@cedum cedum commented Sep 26, 2019

.represent_boolean_as_integer= is always true. Setting this is
deprecated and will be removed in Rails 6.1

Not sure if this is the right way to handle these types of deprecations.

Ref: rails/rails@f59b081

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)

kennyadsl
kennyadsl reviewed Sep 26, 2019
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a suggestion about removing a code comment, the rest is 👍 for me, thanks!

core/lib/spree/testing_support/dummy_app.rb Outdated Show resolved Hide resolved
@cedum
Disable deprecation warning for Rails 6 in DummyApp
5e26b9f 
`.represent_boolean_as_integer=` is always true. Setting this is
deprecated and will be removed in Rails 6.1
@cedum cedum force-pushed the cedum/disable-deprecation-warning branch from cbe9b7c to 5e26b9f Compare September 26, 2019 08:46
spaghetticode
spaghetticode approved these changes Sep 27, 2019
View reviewed changes
Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cedum thank you 👍

kennyadsl
kennyadsl approved these changes Sep 27, 2019
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kennyadsl kennyadsl merged commit 7ea369c into solidusio:master Sep 27, 2019
@kennyadsl kennyadsl deleted the cedum/disable-deprecation-warning branch September 27, 2019 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennyadsl kennyadsl kennyadsl approved these changes

@spaghetticode spaghetticode spaghetticode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cedum @spaghetticode @kennyadsl