Paginate master prices #3353
Merged
Paginate master prices #3353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A row with a col-12 inside does exactly nothing.
Otherwise, for very long lists of prices, users cannot see they exist.
mamhoff
force-pushed
the
paginate-master-prices
branch
from
26923f7 to
35baeca
Compare
jacobherrington
suggested changes
Sep 27, 2019
There was a problem hiding this comment.
Hi @mamhoff Thanks for the PR 😁 Do you mind taking a screenshot of this change?
|
Before: After: |
spaghetticode
approved these changes
Sep 27, 2019
|
@jacobherrington can you please re-review when you have time? |
|
ping @jacobherrington please re-review |
jacobherrington
approved these changes
Oct 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds pagination to the prices list of products that do not have variants. I do not think this change needs a spec.
Checklist: