Officialize new taxation system #3354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are not using this method in the codebase and now we have Spree::Tax::OrderAdjuster class which takes care of applying taxes to an order. That's the new default way and we should start printing a notice into apps/extensions that are still using the old way.
kennyadsl
force-pushed
the
kennyadsl/deprecate-tax-rate-adjust
branch
from
8fa5121 to
486db3a
Compare
spaghetticode
approved these changes
Sep 27, 2019
DanielePalombo
added a commit
to nebulab/solidus
that referenced
this pull request
Nov 13, 2020
in favour of Spree::Tax::orderAdjuster#adjust! solidusio#3354
kennyadsl
pushed a commit
to nebulab/solidus
that referenced
this pull request
Nov 17, 2020
in favour of Spree::Tax::orderAdjuster#adjust! solidusio#3354
kennyadsl
pushed a commit
to nebulab/solidus
that referenced
this pull request
Nov 19, 2020
in favour of Spree::Tax::orderAdjuster#adjust! solidusio#3354
kennyadsl
pushed a commit
to nebulab/solidus
that referenced
this pull request
Nov 27, 2020
in favour of Spree::Tax::orderAdjuster#adjust! solidusio#3354
kennyadsl
pushed a commit
to nebulab/solidus
that referenced
this pull request
Nov 27, 2020
in favour of Spree::Tax::orderAdjuster#adjust! solidusio#3354
kennyadsl
pushed a commit
to nebulab/solidus
that referenced
this pull request
Dec 9, 2020
in favour of Spree::Tax::orderAdjuster#adjust! solidusio#3354
kennyadsl
pushed a commit
to nebulab/solidus
that referenced
this pull request
Dec 10, 2020
in favour of Spree::Tax::orderAdjuster#adjust! solidusio#3354
DanielePalombo
added a commit
to nebulab/solidus
that referenced
this pull request
Dec 11, 2020
in favour of Spree::Tax::orderAdjuster#adjust! solidusio#3354
kennyadsl
pushed a commit
to nebulab/solidus
that referenced
this pull request
Dec 15, 2020
in favour of Spree::Tax::orderAdjuster#adjust! solidusio#3354
DanielePalombo
added a commit
to nebulab/solidus
that referenced
this pull request
Dec 18, 2020
in favour of Spree::Tax::orderAdjuster#adjust! solidusio#3354
kennyadsl
pushed a commit
to nebulab/solidus
that referenced
this pull request
Dec 21, 2020
in favour of Spree::Tax::orderAdjuster#adjust! solidusio#3354
kennyadsl
pushed a commit
to nebulab/solidus
that referenced
this pull request
Jan 19, 2021
in favour of Spree::Tax::orderAdjuster#adjust! solidusio#3354
kennyadsl
pushed a commit
to nebulab/solidus
that referenced
this pull request
Jan 28, 2021
in favour of Spree::Tax::orderAdjuster#adjust! solidusio#3354
kennyadsl
pushed a commit
to nebulab/solidus
that referenced
this pull request
Jan 28, 2021
in favour of Spree::Tax::orderAdjuster#adjust! solidusio#3354
rmparr
pushed a commit
to rmparr/solidus
that referenced
this pull request
Jun 1, 2022
in favour of Spree::Tax::orderAdjuster#adjust! solidusio#3354
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ref: #1892
We should have probably done this long time ago, but I think we should start deprecating methods that we don't want to see anymore in stores and extensions.
Having the new way for calculating order taxes marked as experimental added some further confusion we can easily remove.
Note
Spree::TaxRate#adjustmethod. I hope it will show us also other places where we are eventually using it and I missed.Checklist:
[ ] I have updated Guides and README accordingly to this change (if needed)[ ] I have added tests to cover this change (if needed)