Added a new page to the documentation for customizing model attributes #3360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennyadsl
reviewed
Oct 2, 2019
guides/source/developers/customizations/customizing-attributes.html.md
Outdated
Show resolved
Hide resolved
guides/source/developers/customizations/customizing-attributes.html.md
Outdated
Show resolved
Hide resolved
guides/source/developers/customizations/customizing-attributes.html.md
Outdated
Show resolved
Hide resolved
cedum
reviewed
Oct 2, 2019
guides/source/developers/customizations/customizing-attributes.html.md
Outdated
Show resolved
Hide resolved
guides/source/developers/customizations/customizing-attributes.html.md
Outdated
Show resolved
Hide resolved
guides/source/developers/customizations/customizing-attributes.html.md
Outdated
Show resolved
Hide resolved
|
@octoxan Thanks, can you please also squash commits into a single one? |
This new page walks through an example of adding a custom attribute, and contains the following sections: - Adding attribute columns to the database, with a link to official Rails migration documentation. - Adding attribute fields to the admin panel, by using Deface, with a link to and mention of the full Customizing Admin Panel page. - Allowing custom attributes to be saved, by editing an initializer and rebooting the Rails server.
@kennyadsl Would you prefer it just be the original commit message, or contain both and say that it's squashed? |
|
The goal is to provide a single block of changes to people that are browsing the repository history. Having two separate commits could only create confusion for them so I think the first one is enough. Thanks again! |
|
@kennyadsl Sounds good, updated. Thanks! |
kennyadsl
approved these changes
Oct 2, 2019
cedum
approved these changes
Oct 4, 2019
|
Closes #3307 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new page walks through an example of adding a custom attribute,
and contains the following sections:
Rails migration documentation.
with a link to and mention of the full Customizing Admin Panel page.
and rebooting the Rails server.
This was to close issue #3307. I believe there was no easy way for developer new to Solidus to know how to add a custom model attribute without extensive Googling or asking on Slack.
Checklist: