-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guides (API): Some additional API token info #3368
Conversation
@felixyz thanks for the contribution. Which Solidus version are you using? Recently, we deprecated |
@kennyadsl 🤦♂️ haha you caught me there, now you can infer just how far behind I am with my updates. How about the other stuff? It's tiny but perhaps worth merging? |
Sure, I like the rest of the PR. This also needs a rebase to fix pending CI checks I guess. Thanks Felix! |
@felixyz do you have time to complete this PR or it's better to close it? |
4e2fd84
to
fde08e6
Compare
@kennyadsl Should be ready now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Felix!
Looking good, thanks! |
UPDATE: Ignore everything below. All that remains is a small extra tip on where to find your API token and a
curl
example.Description
The API guide states that the API token should be passed in through the
Authentication
header. I discovered this doesn't work, and from this line it looks like the correct header isX-Spree-Token
, which also works in practice for me.Either I misunderstood something, or the guides are wrong.
I also added a
curl
example and spelled out where people can find their admin token.Checklist: