Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add steps for installing database gems #3380

Merged
merged 1 commit into from
Oct 15, 2019
Merged

Add steps for installing database gems #3380

merged 1 commit into from
Oct 15, 2019

Conversation

codykaup
Copy link

Description
I just started playing around with Solidus and noticed some hiccups during the setup process. Turns out, there's a DB environment variable that's used to indicate which database you want to use. This also scopes down the database-related gems that are needed to install. DB should also be used during bundle install so you gather the correct gems during setup.

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)

Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @codykaup!

Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codykaup thanks 👍

@kennyadsl kennyadsl merged commit 0d93620 into solidusio:master Oct 15, 2019
@codykaup codykaup deleted the tweak-setup-steps branch October 15, 2019 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants