Update custom search sample query #3396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JDutil
reviewed
Oct 23, 2019
| @@ -51,7 +51,7 @@ module MyStore | |||
| private | |||
|
|
|||
| def get_base_scope | |||
| super.where("name LIKE '%rails%'") | |||
| super.where("name LIKE '%Rails%'") | |||
There was a problem hiding this comment.
Are my sandbox seeds not loading all products? I only see "Ruby" products, and not any "Rails" products. If the seeds only populate "Ruby" products perhaps we should change this query to %Ruby%.
There was a problem hiding this comment.
Looks like the sandbox only has "Ruby" products https://github.com/solidusio/solidus/blob/master/sample/db/samples/products.rb while the
spaghetticode
approved these changes
Oct 25, 2019
|
@peterberkenbosch can you please take a look at the @JDutil comment here? Thanks! |
peterberkenbosch
force-pushed
the
fix-search-sample-code
branch
from
f9a1ae8 to
a40fb94
Compare
|
This should be all good now @kennyadsl, thanks @JDutil |
This commit fixes a documentation issue, since we do not load RoR products any longer (8221dcb) the documentation is updated to use Ruby named products.
peterberkenbosch
force-pushed
the
fix-search-sample-code
branch
from
a40fb94 to
bacf297
Compare
ericsaupe
approved these changes
Feb 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the query to have an uppercase R to actually return the sample products.
Description
Checklist: