Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use proper fixture path for Backend file fixtures #3424

Merged
merged 1 commit into from
Nov 14, 2019
Merged

Use proper fixture path for Backend file fixtures #3424

merged 1 commit into from
Nov 14, 2019

Conversation

JuanCrg90
Copy link
Contributor

@JuanCrg90 JuanCrg90 commented Nov 10, 2019 •
edited
Loading

Description
backend/spec/support/ is not the best place for fixture files. This
creates the /spec/fixture/files directory path and updates the tests to
use file_fixture instead of a hardcoded file path.

closes #3421

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

@JuanCrg90
Use proper fixture path for Backend file fixtures
000b13c 
backend/spec/support/ is not the best place for fixture files. This
creates the /spec/fixture/files directory path and updates the tests to
use file_fixture instead of a hardcoded file path.
spaghetticode
spaghetticode approved these changes Nov 10, 2019
View reviewed changes
Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuanCrg90 thank you! 👍

kennyadsl
kennyadsl approved these changes Nov 14, 2019
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JuanCrg90 !

@kennyadsl kennyadsl merged commit 9119d6c into solidusio:master Nov 14, 2019
@JuanCrg90 JuanCrg90 deleted the chore/use-proper-fixture-backend branch November 14, 2019 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennyadsl kennyadsl kennyadsl approved these changes

@spaghetticode spaghetticode spaghetticode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use proper fixture path for backend file fixtures
3 participants
@JuanCrg90 @spaghetticode @kennyadsl