Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Slack links in README. #3433

Merged
merged 1 commit into from
Nov 22, 2019

Conversation

jrgifford
Copy link
Contributor

Description

The directions to join the Slack group and channels were inconsistent.

Previously the links would take you to solidusio.slack.com, when they should have been taking folks to slack.solidus.io.

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

@jrgifford jrgifford changed the title Update slack links in README. Update Slack links in README. Nov 20, 2019
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jrgifford, glad we found this at RubyConf.

Super excited to have you as a contributor! 👏

@spaghetticode spaghetticode merged commit 937a7b8 into solidusio:master Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants