Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates Guides: Security and simple installation #3436

Merged
merged 4 commits into from
Dec 2, 2019
Merged

Updates Guides: Security and simple installation #3436

merged 4 commits into from
Dec 2, 2019

Conversation

kennyadsl
Copy link
Member

@kennyadsl kennyadsl commented Nov 22, 2019 •
edited
Loading

Description
This PR updates Guides, mainly to:

  • update security test
  • update install guide to suggest not installing webpack if a simple Solidus store is needed
  • use flat color as header background, there's no need for the purple gradient.

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

@kennyadsl kennyadsl self-assigned this Nov 22, 2019
spaghetticode
spaghetticode approved these changes Nov 29, 2019
View reviewed changes
Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kennyadsl thank you 👍

@kennyadsl
[Guides] Suggest not installing webpacker for simple stores
20ff629 
For the default Solidus functionalities, Webpacker installation
is not required. Now that it's installed by deafult with Rails
we should avoid adding it to the app if it's not needed/used.
@kennyadsl
[Guides] Avoid links to go to new lines
2a93873 
It's useless to have the display: inline-block property
on links and it's causing some links to break the line.
@kennyadsl
[Guides] Update security section
36b9222
@kennyadsl
[Guides] Use a flat color as header background
52b4264
@kennyadsl kennyadsl force-pushed the kennyadsl/guide-updates branch from 4055a37 to 52b4264 Compare December 2, 2019 12:01
@kennyadsl kennyadsl merged commit 6aa7436 into solidusio:master Dec 2, 2019
@kennyadsl kennyadsl deleted the kennyadsl/guide-updates branch December 2, 2019 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobherrington jacobherrington jacobherrington approved these changes

@spaghetticode spaghetticode spaghetticode approved these changes

Assignees

@kennyadsl kennyadsl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kennyadsl @spaghetticode @jacobherrington