Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax Paperclip dependency #3438

Merged
merged 1 commit into from
Nov 27, 2019
Merged

Conversation

mamhoff
Copy link
Contributor

@mamhoff mamhoff commented Nov 26, 2019

Paperclip 6 allows use of the AWS SDK gem v3, which allows ONLY loading
the libraries used for S3 and no others, while otherwise maintaining API
compatibility. Less bytes over the wire!

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

Paperclip 6 allows use of the AWS SDK gem v3, which allows ONLY loading
the libraries used for S3 and no others, while otherwise maintaining API
compatibility. Less bytes over the wire!
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This allows stores to update to latest Paperclip version. Since 6.0 does not contain any breaking changes, but only that dependency change, this should be fine even in a minor version.

@tvdeyen tvdeyen mentioned this pull request Nov 26, 2019
7 tasks
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mamhoff

@kennyadsl kennyadsl merged commit d37f57f into solidusio:master Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants