Allow configuring VAT Price Generator class #3451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is common that stores need to configure how VAT is calculated and we should provide an easy extension point to make this change as clean as possible.
mamhoff
approved these changes
Dec 10, 2019
There was a problem hiding this comment.
This looks really good!
I have a suggestion though: Given that this requirement is quite common (and also given that the example we give in this PR matches Spree's VAT logic!), we might want to ship both classes within core, maybe with these class names:
Spree::Variant::ConstantNetVatPricegenerator(aliased to the currentSpree::Variant::VatPriceGenerator)Spree::Variant::ContantGrossVatPriceGenerator(the implementation from the docs in this PR)?
|
That's a great idea. Wondering if this should be done at a TaxRate level. I mean when we decide that a tax rate is incuded in price we could also give admin the ability to choose if they want it constant net or constant gross. Do you think it makes sense this way? |
waiting-for-dev
deleted the
kennyadsl/make-vat-price-generator-configurable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current VAT generation logic provided by Solidus is not flexible enough to match any business needs, see #3448.
This PR allows to easily create your own custom class to generate VAT prices and use it in Solidus. It also adds a simple explanation in Guides with a realistic example, taken from the issue mentioned above.
Checklist:
[ ] I have added tests to cover this change (if needed)[ ] I have attached screenshots to this PR for visual changes (if needed)