Refactor Spree::Address value_attributes #3465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 20, 2019
spaghetticode
approved these changes
Dec 23, 2019
filippoliverani
force-pushed
the
refactor-address-value-attributes
branch
from
1e64f5c to
6a28a60
Compare
aldesantis
requested changes
Dec 23, 2019
There was a problem hiding this comment.
@filippoliverani looking good, but can you remove the commit by dependabot?
filippoliverani
force-pushed
the
refactor-address-value-attributes
branch
from
6a28a60 to
8c6d93d
Compare
Preparatory refactoring to simplify code and make easier changing value_attributes code in incoming PRs. Removing some conditionals and in-place hash updates will make adding new `name` handling business logic more straightforward.
filippoliverani
force-pushed
the
refactor-address-value-attributes
branch
from
8c6d93d to
df6aa1a
Compare
@aldesantis Sorry, it slipped in during a rebase, removed 👍 |
aldesantis
approved these changes
Dec 23, 2019
jacobherrington
approved these changes
Jan 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Preparatory refactoring to simplify
Spree::Addresscode and make easier working on #3234.Checklist: